-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PyPIRepository::resolve_reqs()
for pip>=22.1.1
#1624
Conversation
I just saw the discussion in #1623. If I get the gist of it right, since pip internals are used by pip-tools, we have to either add conditionals like the one here, or we need to vendor pip. So until a decision is made on vendoring, this should be an ok solution. |
Only Ubuntu 3.11-dev is failing and it doesn't seem related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'll merge and prepare the release shortly. |
@atugushev That was my plan. Merge whatever is ready and safe to merge and tag a new release to fix the serious bug with newer pip. |
PyPIRepository::resolve_reqs()
for pip>=22.1.1
Currently, things are failing due to pip-tools not working with pip >= 22.1.1. So avoid these versions until jazzband/pip-tools#1624 is merged and found in released version. Signed-off-by: Arnaud Patard <[email protected]>
* tox.ini: Set skipsdist On my debian bullseye system, tox is complaining: ERROR: No pyproject.toml or setup.py file found. The expected locations are: ... Set skipsdist to True to avoid that. Signed-off-by: Arnaud Patard <[email protected]> * tox.ini: Avoid pip >= 22.1.1 Currently, things are failing due to pip-tools not working with pip >= 22.1.1. So avoid these versions until jazzband/pip-tools#1624 is merged and found in released version. Signed-off-by: Arnaud Patard <[email protected]> * negative_test/roles/meta_invalid_role_namespace/meta/main.yml.md: update Update file with version generated out of tox run. Signed-off-by: Arnaud Patard <[email protected]> * Update tox.ini Co-authored-by: Sorin Sbarnea <[email protected]>
Thanks for the quick release! |
This commit upgrades the version of pip-tools used in this repository from 6.6.0 to 6.6.2. In version 6.6.0 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'". The error was reported here: jazzband/pip-tools#1617. The fix to this bug was released in version 6.6.2 of pip-tools. See the comment here: jazzband/pip-tools#1617 (comment). Version 6.6.1 of pip-tools also has a bug, which is fixed in version 6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to 6.6.2. The issue in version 6.6.1 was reported here: jazzband/pip-tools#1624.
This commit upgrades the version of pip-tools used in this repository from 6.6.0 to 6.6.2. In version 6.6.0 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'". The error was reported here: jazzband/pip-tools#1617. The fix to this bug was released in version 6.6.2 of pip-tools. See the comment here: jazzband/pip-tools#1617 (comment). Version 6.6.1 of pip-tools also has a bug, which is fixed in version 6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to 6.6.2. The issue in version 6.6.1 was reported here: jazzband/pip-tools#1624.
This commit upgrades the version of pip-tools used in this repository from 6.6.1 to 6.6.2. In version 6.6.1 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "AttributeError: 'RequirementSet' object has no attribute 'add_requirement'". The error was reported here: jazzband/pip-tools#1623. The fix to this bug was released in version 6.6.2 of pip-tools. See the pull request here: jazzband/pip-tools#1624.
This commit upgrades the version of pip-tools used in this repository from 6.6.0 to 6.6.2. In version 6.6.0 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'". The error was reported here: jazzband/pip-tools#1617. The fix to this bug was released in version 6.6.2 of pip-tools. See the comment here: jazzband/pip-tools#1617 (comment). Version 6.6.1 of pip-tools also has a bug, which is fixed in version 6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to 6.6.2. The issue in version 6.6.1 was reported here: jazzband/pip-tools#1624.
This commit upgrades the version of pip-tools used in this repository from 6.6.0 to 6.6.2. In version 6.6.0 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'". The error was reported here: jazzband/pip-tools#1617. The fix to this bug was released in version 6.6.2 of pip-tools. See the comment here: jazzband/pip-tools#1617 (comment). Version 6.6.1 of pip-tools also has a bug, which is fixed in version 6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to 6.6.2. The issue in version 6.6.1 was reported here: jazzband/pip-tools#1624.
This commit upgrades the version of pip-tools used in this repository from 6.6.0 to 6.6.2. In version 6.6.0 of pip-tools, there is a bug that is preventing pip-tools from working. This is breaking the Python requirements update GitHub action in this repository. The error is "ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'". The error was reported here: jazzband/pip-tools#1617. The fix to this bug was released in version 6.6.2 of pip-tools. See the comment here: jazzband/pip-tools#1617 (comment). Version 6.6.1 of pip-tools also has a bug, which is fixed in version 6.6.2. I observed this issue breaking the Python requirements update GitHub action in another repository, so I have upgrade the version straight to 6.6.2. The issue in version 6.6.1 was reported here: jazzband/pip-tools#1624.
pip 22.1.1 splits RequirementSet::add_requirement() to RequirementSet::add_named_requirement() and RequirementSet::add_unnamed_requirement(). Here, we update PyPIRepository::resolve_reqs() to call the right method.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.Fixes #1623